Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORML integration #1136

Closed
wants to merge 15 commits into from
Closed

ORML integration #1136

wants to merge 15 commits into from

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Jan 31, 2024

Resolves: SNO-839

  • Prepare template chain as submodule
  • Initialize with minimal ORML traits/pallets required
  • Bridge adaptor for token transfer
  • Emulated tests

Primary changes in Snowfork/parachain-orml-template#1 as reference for the ORML integration.

Emulated test transferring WETH from ethereum to orml-template chain and vice versa.

@yrong yrong changed the title ORML xcm integration ORML integration Feb 1, 2024
@yrong yrong marked this pull request as ready for review February 2, 2024 10:49
@yrong
Copy link
Contributor Author

yrong commented Feb 5, 2024

Currently, the workflow requires token transfer messages all relayed from Asset Hub(AH), so from the perspective of the ORML chain there is not much difference from the integration flow with any other sibling chain(e.g. mainly to register foreign token and it's XCM Location in asset-registry module which the 3rd team should already be familiar with).

Previously I planned to add the template chain into our e2e setup and write smoke tests for it, but consider above seems not worthwhile for that. The emulated test and the companion PR with changes required should be pretty enough for demonstration. Meanwhile we may not want to keep maintaining the orml codes always to recent release.

So I prefer not to merge this PR and just leave it here as a reference for the integration flow.

@vgeddes
Copy link
Collaborator

vgeddes commented Feb 5, 2024

Sounds good Ron, I agree that we should not merge this since the Snowfork/parachain-orml-template repo should be sufficient.

@yrong
Copy link
Contributor Author

yrong commented Feb 6, 2024

Leave Snowfork/parachain-orml-template#1 and close this one.

@yrong yrong closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants